mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-14 10:34:06 +02:00
Anthony StirlingandGitHub
4fa67afc3d
## Summary Regression from #6404 (Restructure/frontend editor). Two CI workflows copy the built installers to the wrong directory, so installer artifacts (MSI / DMG / DEB / RPM / AppImage) silently vanish: - **`tauri-build.yml`** (PR/desktop smoke builds) - uploads zero installer artifacts. - **`multiOSReleases.yml`** (production releases) - the empty artifacts are downloaded by `create-release` and fed to `action-gh-release`, so a release would publish **only the JARs, no desktop installers**. ## Root cause #6404 moved the Tauri project from `frontend/` to `frontend/editor/` and updated every **absolute** path (`projectPath`, `cd`, `Get-ChildItem`) to add the `editor/` segment - but left the **relative** copy targets `../../../dist`. Those resolve against the (now one level deeper) working dir after `cd ./frontend/editor/src-tauri/target`: | | resolves to | |---|---| | before #6404 (`frontend/src-tauri/target`) | repo-root `dist/` ✅ | | after #6404 (`frontend/editor/src-tauri/target`) | `frontend/dist/` ❌ (missing) | The `cp` fails, repo-root `dist/` (from `mkdir -p ./dist`) stays empty, and the upload finds nothing. `find -exec cp` failing is non-fatal, so jobs still report success - that's why it went unnoticed. No release has shipped broken yet: the last release (v2.11.0, 2026-05-19) predates #6404 (2026-05-22). ## Fix Copy to an absolute `$GITHUB_WORKSPACE/dist` in both workflows so the `cd` can't drift the destination again. This matches where the upload / signature-verify steps already read from. ## Evidence (run 26574078559, all 3 OS legs) ``` cp: cannot create regular file '../../../dist/Stirling-PDF-windows-x86_64.msi': No such file or directory ##[warning]No files were found with the provided path: ./dist/*. No artifacts will be uploaded. ``` The Tauri builds themselves succeeded - only the copy/upload was broken. ## Test plan - [ ] `tauri-build` on this PR uploads non-empty `Stirling-PDF-<name>` artifacts on Windows/macOS/Linux. - [ ] Next release (or a `workflow_dispatch` of multiOSReleases) attaches MSI/DMG/DEB/RPM/AppImage to the release.