mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-16 03:20:46 +02:00
James BruntonandGitHub
a3e45bc182
# Description of Changes Changes the strategy for autoformatting to reject PRs if they are not formatted correctly instead of allowing them to merge and then spawning a new PR to fix the formatting. The old strategy just caused more work for us because we'd have to manually approve the followup PR and get it merged, which required 2 reviewers so in practice it rarely got done and just meant everyone's PRs ended up containing reformatting for unrelated files, which makes code review unnecessarily difficult. If the PR's code is not formatted correctly after this PR, a comment will be added automatically to tell the author how to run the formatter script to fix their code so it can go in. This also enables autoformatting for the frontend code, using Prettier. I've enabled it for pretty much everything in the frontend folder, other than 3rd party files and files it doesn't make sense for. I also excluded Markdown because it sounds likely to be more annoying to have to autoformat the Markdown in the frontend folder but nowhere else. Open to changing this though if people disagree. > [!note] > > Advice to reviewers: The first commit contains all of the actual logic I've introduced (CI changes, Prettier config, etc.) > The second commit is just the reformatting of the entire frontend folder. > The first commit needs proper review, the second one just give it a spot-check that it's doing what you'd expect.
15 lines
588 B
TypeScript
15 lines
588 B
TypeScript
import { Navigate } from "react-router-dom";
|
|
|
|
/**
|
|
* Desktop override of the /login route.
|
|
* The legacy web login page must never appear in desktop builds — authentication
|
|
* is handled exclusively through the DesktopOnboardingModal and SignInModal.
|
|
* Any navigation to /login (e.g. from Spring Boot auth redirects) is intercepted
|
|
* here and immediately redirected to /.
|
|
* The sign-in modal is opened by the desktop httpErrorHandler before navigation
|
|
* occurs, so no additional dispatch is needed here.
|
|
*/
|
|
export default function Login() {
|
|
return <Navigate to="/" replace />;
|
|
}
|