mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-15 11:00:47 +02:00
James BruntonandGitHub
a3e45bc182
# Description of Changes Changes the strategy for autoformatting to reject PRs if they are not formatted correctly instead of allowing them to merge and then spawning a new PR to fix the formatting. The old strategy just caused more work for us because we'd have to manually approve the followup PR and get it merged, which required 2 reviewers so in practice it rarely got done and just meant everyone's PRs ended up containing reformatting for unrelated files, which makes code review unnecessarily difficult. If the PR's code is not formatted correctly after this PR, a comment will be added automatically to tell the author how to run the formatter script to fix their code so it can go in. This also enables autoformatting for the frontend code, using Prettier. I've enabled it for pretty much everything in the frontend folder, other than 3rd party files and files it doesn't make sense for. I also excluded Markdown because it sounds likely to be more annoying to have to autoformat the Markdown in the frontend folder but nowhere else. Open to changing this though if people disagree. > [!note] > > Advice to reviewers: The first commit contains all of the actual logic I've introduced (CI changes, Prettier config, etc.) > The second commit is just the reformatting of the entire frontend folder. > The first commit needs proper review, the second one just give it a spot-check that it's doing what you'd expect.
34 lines
1.1 KiB
TypeScript
34 lines
1.1 KiB
TypeScript
/**
|
|
* Desktop Override: Onboarding Configuration
|
|
*
|
|
* This version modifies the onboarding config for the desktop app:
|
|
* - Sets isDesktopApp to true in the default runtime state
|
|
* - This causes desktop-install step to be skipped
|
|
*
|
|
* All other step definitions and logic remain the same.
|
|
*/
|
|
|
|
// Re-export everything from core
|
|
export { ONBOARDING_STEPS, getStepById, getStepIndex } from "@core/components/onboarding/orchestrator/onboardingConfig";
|
|
|
|
export type {
|
|
OnboardingStepId,
|
|
OnboardingStepType,
|
|
OnboardingStep,
|
|
OnboardingRuntimeState,
|
|
OnboardingConditionContext,
|
|
} from "@core/components/onboarding/orchestrator/onboardingConfig";
|
|
|
|
// Import and override the default runtime state
|
|
import { DEFAULT_RUNTIME_STATE as CORE_DEFAULT_RUNTIME_STATE } from "@core/components/onboarding/orchestrator/onboardingConfig";
|
|
import type { OnboardingRuntimeState } from "@core/components/onboarding/orchestrator/onboardingConfig";
|
|
|
|
/**
|
|
* Desktop default runtime state
|
|
* Sets isDesktopApp to true so desktop-install step is skipped
|
|
*/
|
|
export const DEFAULT_RUNTIME_STATE: OnboardingRuntimeState = {
|
|
...CORE_DEFAULT_RUNTIME_STATE,
|
|
isDesktopApp: true,
|
|
};
|