mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-15 02:54:06 +02:00
# Description of Changes Changes the strategy for autoformatting to reject PRs if they are not formatted correctly instead of allowing them to merge and then spawning a new PR to fix the formatting. The old strategy just caused more work for us because we'd have to manually approve the followup PR and get it merged, which required 2 reviewers so in practice it rarely got done and just meant everyone's PRs ended up containing reformatting for unrelated files, which makes code review unnecessarily difficult. If the PR's code is not formatted correctly after this PR, a comment will be added automatically to tell the author how to run the formatter script to fix their code so it can go in. This also enables autoformatting for the frontend code, using Prettier. I've enabled it for pretty much everything in the frontend folder, other than 3rd party files and files it doesn't make sense for. I also excluded Markdown because it sounds likely to be more annoying to have to autoformat the Markdown in the frontend folder but nowhere else. Open to changing this though if people disagree. > [!note] > > Advice to reviewers: The first commit contains all of the actual logic I've introduced (CI changes, Prettier config, etc.) > The second commit is just the reformatting of the entire frontend folder. > The first commit needs proper review, the second one just give it a spot-check that it's doing what you'd expect.
116 lines
4.4 KiB
TypeScript
116 lines
4.4 KiB
TypeScript
// frontend/src/services/httpErrorHandler.ts
|
|
import { alert } from "@app/components/toast";
|
|
import { broadcastErroredFiles, extractErrorFileIds, normalizeAxiosErrorData } from "@app/services/errorUtils";
|
|
import { showSpecialErrorToast } from "@app/services/specialErrorToasts";
|
|
import { handleSaaSError } from "@app/services/saasErrorInterceptor";
|
|
import { clampText, extractAxiosErrorMessage } from "@app/services/httpErrorUtils";
|
|
|
|
// Module-scoped state to reduce global variable usage
|
|
const recentSpecialByEndpoint: Record<string, number> = {};
|
|
const SPECIAL_SUPPRESS_MS = 1500; // brief window to suppress generic duplicate after special toast
|
|
|
|
/**
|
|
* Handles HTTP errors with toast notifications and file error broadcasting
|
|
* Returns true if the error should be suppressed (deduplicated), false otherwise
|
|
*/
|
|
export async function handleHttpError(error: any): Promise<boolean> {
|
|
const skipAuthRedirect = error?.config?.skipAuthRedirect === true;
|
|
// Check if this error should skip the global toast (component will handle it)
|
|
if (error?.config?.suppressErrorToast === true) {
|
|
return false; // Don't show global toast, but continue rejection
|
|
}
|
|
|
|
// Handle 401 authentication errors
|
|
const status: number | undefined = error?.response?.status;
|
|
if (status === 401) {
|
|
const pathname = window.location.pathname;
|
|
|
|
// Check if we're already on an auth page
|
|
const isAuthPage =
|
|
pathname.includes("/login") ||
|
|
pathname.includes("/signup") ||
|
|
pathname.includes("/auth/") ||
|
|
pathname.includes("/invite/");
|
|
|
|
// If not on auth page, redirect to login with expired session message
|
|
if (!isAuthPage && !skipAuthRedirect) {
|
|
console.debug("[httpErrorHandler] 401 detected, redirecting to login");
|
|
// Store the current location so we can redirect back after login
|
|
const currentLocation = window.location.pathname + window.location.search;
|
|
// Redirect to login with state (only show expired when a JWT existed)
|
|
let hadStoredJwt = false;
|
|
try {
|
|
hadStoredJwt = Boolean(localStorage.getItem("stirling_jwt"));
|
|
} catch {
|
|
// ignore storage access failures
|
|
}
|
|
const expiredPrefix = hadStoredJwt ? "expired=true&" : "";
|
|
window.location.href = `/login?${expiredPrefix}from=${encodeURIComponent(currentLocation)}`;
|
|
return true; // Suppress toast since we're redirecting
|
|
}
|
|
|
|
// On auth pages, suppress the toast (user is already trying to authenticate)
|
|
console.debug("[httpErrorHandler] Suppressing 401 on auth page:", pathname);
|
|
return true;
|
|
}
|
|
|
|
if (handleSaaSError(error)) return true;
|
|
|
|
// Compute title/body (friendly) from the error object
|
|
const { title, body } = extractAxiosErrorMessage(error);
|
|
|
|
// Normalize response data ONCE, reuse for both ID extraction and special-toast matching
|
|
const raw = error?.response?.data as any;
|
|
let normalized: unknown = raw;
|
|
try {
|
|
normalized = await normalizeAxiosErrorData(raw);
|
|
} catch (e) {
|
|
console.debug("normalizeAxiosErrorData", e);
|
|
}
|
|
|
|
// 1) If server sends structured file IDs for failures, also mark them errored in UI
|
|
try {
|
|
const ids = extractErrorFileIds(normalized);
|
|
if (ids && ids.length > 0) {
|
|
broadcastErroredFiles(ids);
|
|
}
|
|
} catch (e) {
|
|
console.debug("extractErrorFileIds", e);
|
|
}
|
|
|
|
// 2) Generic-vs-special dedupe by endpoint
|
|
const url: string | undefined = error?.config?.url;
|
|
const now = Date.now();
|
|
const isSpecial =
|
|
status === 422 ||
|
|
status === 409 || // often actionable conflicts
|
|
/Failed files:/.test(body) ||
|
|
/invalid\/corrupted file\(s\)/i.test(body);
|
|
|
|
if (isSpecial && url) {
|
|
recentSpecialByEndpoint[url] = now;
|
|
}
|
|
if (!isSpecial && url) {
|
|
const last = recentSpecialByEndpoint[url] || 0;
|
|
if (now - last < SPECIAL_SUPPRESS_MS) {
|
|
return true; // Suppress this error (deduplicated)
|
|
}
|
|
}
|
|
|
|
// 3) Show specialized friendly toasts if matched; otherwise show the generic one
|
|
let rawString: string | undefined;
|
|
try {
|
|
rawString = typeof normalized === "string" ? normalized : JSON.stringify(normalized);
|
|
} catch (e) {
|
|
console.debug("extractErrorFileIds", e);
|
|
}
|
|
|
|
const handled = showSpecialErrorToast(rawString, { status });
|
|
if (!handled) {
|
|
const displayBody = clampText(body);
|
|
alert({ alertType: "error", title, body: displayBody, expandable: true, isPersistentPopup: false });
|
|
}
|
|
|
|
return false; // Error was handled with toast, continue normal rejection
|
|
}
|