2 Commits

Include renames

Author	SHA1	Message	Date
Anthony StirlingandGitHub	1ef03c43b4	fix(i18n): wrap hard-coded English strings in t() across UI (#6566) ... ## Summary Audit + bulk fix of hard-coded English UI strings - `aria-label`, `title`, `placeholder`, `label`, and raw JSX literals that bypassed i18n entirely. Each literal now goes through `t("key", "English Default")` from `react-i18next`, and every new key has a corresponding entry in `en-GB/translation.toml` so translators can pick it up. ## What this fixes Strings were rendered untranslated in every non-EN locale because they never went through `t()` at all (not just "value not translated yet"). Affects screen-reader labels, tooltips, form placeholders, empty/loading states, plan card content, and the entire workflow ParticipantView. ## Coverage (~143 keys / 50 files) - **Viewer chrome** - search bar (close, clear, prev/next, "of N" results), link/signature/redaction actions, viewer error state, zoom labels - **Page editor** - undo/redo/rotate/delete toolbar tooltips, empty state, bulk selection operator chip tooltips - **Shared primitives** - Tooltip close, InfoBanner dismiss, TextInput clear, Toast dismiss/toggle, UpdateModal close, EditableSecretField edit, DropdownListWithFooter search, FileCard/FileDropdownMenu actions, EmptyFilesState + AddFileCard upload - **Tools** - Image upload + hint, ColorControl eyedropper, sign Use Signature, CompressSettings, OCR loading, PageLayout margin/border/row/col placeholders, FormFill switch + save + re-scan - **Proprietary admin** - OverviewHeader signed-in line + logout, AdminPremiumSection moved-features list (via `<Trans>`), AdminPlanSection no-data alert, AdminAdvancedSection temp-dir placeholders, AdminEndpointsSection multiselect placeholders, AdminMailSection + AdminDatabaseSection password placeholders - **Onboarding** - MFASetupSlide QR loading + auth code label, SecurityCheckSlide role select + options - **ParticipantView** - entire sign-document UI (~30 strings: loading, error, badges, headings, cert-type Select, all input labels and placeholders, action buttons, completion + expired alerts) - file previously imported `useTranslation` but only used `t()` for cert validation - **planConstants.ts refactor** - replaced `PLAN_FEATURES` / `PLAN_HIGHLIGHTS` const exports with `usePlanFeatures()` / `usePlanHighlights()` hooks. Service layer (`licenseService.getPlans`) updated to accept feature/highlight maps so it stays hook-free. Callers (`usePlans`, `CheckoutContext`) resolve the hooks at the React boundary - **Previously catalogued offenders** - `FileSidebarFileItem` open/close-viewer aria-labels, `quickAccessBar/ActiveToolButton` "Back to all tools" tooltip + aria, `AppConfigModal` close button ## Notes - One small refactor in `usePageSelectionTips.ts` was needed to resolve a TOML key-shape conflict: the existing scalar keys `bulkSelection.operators.{and,not,comma}` needed to become tables to hold the new `.title` subkeys for OperatorsSection's chip tooltips. The existing descriptions moved to `[bulkSelection.operators.descriptions]` and the three i18n key paths in usePageSelectionTips were updated to match. - Viewer sidebar close buttons (Bookmark/Layer/Thumbnail/Attachment/Comments) were on the audit list but are NOT on main - they're added by the unmerged PR #6552 (feat/viewer-sidebar-ux). Those particular strings will need wrapping when that PR lands. - TOML hook (`toml-sort-fix`) ran and re-sorted the translation file. ## Test plan - [ ] `task frontend:typecheck` passes (core + proprietary + desktop variants) - [ ] `task frontend:lint` passes - [ ] Switching language to Deutsch / Русский: previously-English `aria-label`s + tooltips + placeholders + plan card bullets now render translated (when the locale has values) or fall back to the English default (when it doesn't) - [ ] Plan page bullet points in EN render unchanged - [ ] Sign-document flow (ParticipantView) renders unchanged in EN	2026-06-08 10:11:43 +00:00
3 people	0a50e765b7	Restructure/frontend editor (#6404) ... ## Move editor under `frontend/editor/` Pure restructure: `frontend/` becomes the workspace, `frontend/editor/` holds the PDF editor. 1775 file renames + 40 wiring edits. No logic changes. ### Why `frontend/` is currently the editor — its `src/`, `public/`, `src-tauri/`, config files all sit at the root. Promoting `frontend/` to a workspace and putting the editor in a sibling folder leaves room for future apps to drop in alongside it, sharing one `package.json` / `node_modules` / lint config / Storybook. ### What moves frontend/ ├── editor/ ← NEW: everything editor-specific │ ├── src/ ← was frontend/src/ │ ├── public/ ← was frontend/public/ │ ├── src-tauri/ ← was frontend/src-tauri/ │ ├── index.html, vite.config.ts, vitest.config.ts, playwright.config.ts │ ├── tsconfig*.json, tailwind.config.js, postcss.config.js │ ├── scripts/ │ ├── .env, .env.desktop, .env.saas │ └── DeveloperGuide.md ├── package.json, package-lock.json, node_modules/ ← workspace install ├── eslint.config.mjs, .prettierrc, .prettierignore ← shared tooling ├── .gitignore └── README.md ### Wiring edits (40 files) - `.taskfiles/frontend.yml`, `desktop.yml`, `e2e.yml` - `build.gradle`, `app/core/build.gradle` - `eslint.config.mjs`, `frontend/package.json`, `.gitignore`, `.prettierignore` - `docker/frontend/Dockerfile` - 8 `.github/workflows/*.yml`, plus `.github/dependabot.yml`, `.github/config/.files.yaml`, `.github/labeler-config-srvaroa.yml` - `scripts/translations/**` - Docs: `AGENTS.md`, `CLAUDE.md`, `ADDING_TOOLS.md`, `DeveloperGuide.md`, `WINDOWS_SIGNING.md`, `devGuide/HowToAddNewLanguage.md`, `frontend/README.md`, `frontend/editor/DeveloperGuide.md` Plus 3 renamed + edited: `editor/vite.config.ts` (env path + node_modules walk-up), `editor/scripts/setup-env.mts` (renamed from `.ts` for `import.meta.url`), `editor/scripts/build-provisioner.mjs` (resolve src-tauri relative to script). ### Verification | Check | Result | |---|---| | `task frontend:typecheck:all` (6 variants) | exit 0 | | `task frontend:lint` (eslint + dpdm) | exit 0 | | `task frontend:format:check` | exit 0 | | `task frontend:test` | 657 tests pass, 50 files | | `task frontend:build:{core,proprietary,saas,desktop,prototypes}` | all green | | `task desktop:build` | full Tauri pipeline → `Stirling-PDF_2.11.0_x64_en-US.msi` | | `playwright test --list --project=stubbed` | 172 tests discovered | `task desktop:build` exercises the heaviest path — Rust + WiX + MSI bundle against the moved `editor/src-tauri/`. If anything in the restructure was wrong it wouldn't have built. ### Test plan - [ ] `frontend-validation.yml` green - [ ] `e2e-stubbed.yml` green - [ ] `tauri-build.yml` green on at least one platform - [ ] `check_toml.yml` runs on a translation-touching PR --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>	2026-05-22 13:40:34 +01:00