ConnorYoh
5a0567cf6a
Error reductions found via analytics ( #3351 )
...
# Description of Changes
Please provide a summary of the changes, including:
- What was changed
- Why the change was made
- Any challenges encountered
Closes #(issue_number)
---
## Checklist
### General
- [ ] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md )
- [ ] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md )
(if applicable)
- [ ] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md )
(if applicable)
- [ ] I have performed a self-review of my own code
- [ ] My changes generate no new warnings
### Documentation
- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/ )
(if functionality has heavily changed)
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags )
(for new translation tags only)
### UI Changes (if applicable)
- [ ] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)
### Testing (if applicable)
- [ ] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing )
for more details.
2025-04-14 23:33:40 +01:00
Pedro Fonseca and Anthony Stirling
1c655f0ba0
Upload File Size Limit ( #3334 )
...
# Description of Changes
The change this PR aims to introduce is a setting for enabling an upload
file size limit. The author of the issue mentioned in this PR wanted
this feature as they themselves enforced a limit of 50MB file sizes on
their NGINX configuration.
This was implemented by adding an entry to the
[settings.yml.template](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/resources/settings.yml.template )
file. This entry has two sub-configurations in which you declare if the
application should enable upload file size limiting and then you declare
the limit itself.
For this to be available in code, a new field in the
[System](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/java/stirling/software/SPDF/model/ApplicationProperties.java#L280 )
class was added, one named `uploadLimit`.
After that, inside the [AppConfig](url) class, a new thymeleaf bean was
created, one called `uploadLimit`. This bean takes the values available
in the `System` class and creates a `long` value representing the limit
value. This value is interpreted as non-existent if it is `0`, otherwise
it is the value in `bytes` of the upload limit.
In order to make this value available in the
[common.html](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/resources/templates/fragments/common.html )
file, where the submitFile form is imported from, a new controller
[GlobalUploadLimitWebController](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/java/stirling/software/SPDF/controller/web/GlobalUploadLimitWebController.java )
was created. This controller has the tag `ControllerAdvice` so that
every controller has the `ModelAttributes` defined within it. I am not
sure if this was a good approach but upon first investigations, I
couldn't find another method to make these attributes available in every
Controller, or template. If there is already a place like this in the
code with this specific purpose, please let me know so I can fix it.
After making these attributes available, I updated the code in
`common.html`to now display the upload limit if it is defined. This was
done with localization in mind.
Lastly, the
[downloader.js](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/resources/static/js/downloader.js )
and
[fileInput.js](https://github.com/PedroPF1234/Stirling-PDF/blob/e52fc0e478e279169329b7e30782d57b2dbd8cbe/src/main/resources/static/js/fileInput.js )
files to include logic to enforce the upload limit if it is defined.
The UI updates, when the upload limit is defined, are as so:
<img width="708" alt="image"
src="https://github.com/user-attachments/assets/4852fa10-2ec3-45cb-83e6-41a102f256d4 "
/>
When the limit is disabled, the page looks exactly as it did before any
implementation:
<img width="707" alt="image"
src="https://github.com/user-attachments/assets/21e5e810-ffdc-4a99-a16d-491aea103709 "
/>\\
Thank you.
Closes #2903
---
## Checklist
### General
- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md )
- [x] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md )
(if applicable)
- [x] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md )
(if applicable)
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings
### Documentation
- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/ )
(if functionality has heavily changed)
- [x] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags )
(for new translation tags only)
### UI Changes (if applicable)
- [x] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)
### Testing (if applicable)
- [x] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing )
for more details.
---------
Co-authored-by: Anthony Stirling <[email protected] >
2025-04-14 09:36:33 +00:00
Ludy
964f948c64
Fix: Context Path Handling and Static Asset Loading Improvements ( #3198 )
...
# Description of Changes
### Summary
This PR improves how Stirling-PDF handles the `context-path`
configuration in both backend and frontend components. It ensures proper
URL generation when a custom `context-path` is set in the application
properties. Additionally, it fixes static asset loading issues related
to relative paths.
### Changes Implemented:
- **Backend Enhancements:**
- Introduced `contextPathStatic` as a static variable in
`SPDFApplication.java` to store the configured
`server.servlet.context-path`.
- Modified log outputs and UI initialization URLs to include
`contextPathStatic`.
- Registered `contextPath` as a Spring Bean in `AppConfig.java` to make
it accessible in templates.
- **Frontend Fixes:**
- Updated JavaScript files (`downloader.js`, `home.js`) to dynamically
retrieve and use `contextPath`.
- Adjusted Thymeleaf template files (`navbar.html`, `home.html`,
`merge-pdfs.html`) to reference `contextPath` correctly.
- Fixed incorrect static file paths (`pdf.worker.mjs`, `pdf.mjs`) by
replacing absolute paths (`/`) with relative ones (`./`).
### Why These Changes?
- Fixes issues where deployments under subpaths (e.g.,
`example.com/stirling-pdf/`) resulted in incorrect asset and navigation
links.
- Ensures compatibility with different deployment configurations where
`context-path` is not `/`.
### Challenges Encountered
- Ensuring all JavaScript and template references were correctly updated
to use `contextPath` dynamically.
- Maintaining backward compatibility for deployments that use `/` as the
context path.
Closes #3193 #3181
---
## Checklist
### General
- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md )
- [x] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md )
(if applicable)
- [ ] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md )
(if applicable)
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings
### Documentation
- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/ )
(if functionality has heavily changed)
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags )
(for new translation tags only)
### UI Changes (if applicable)
- [ ] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)
### Testing (if applicable)
- [ ] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing )
for more details.
2025-03-20 07:53:29 +00:00
Reece Browne
bf95ca43dc
Remove append entirely
2024-12-18 11:47:23 +00:00
Reece Browne
678ef85da1
Don't remove files from file input, just append
2024-12-18 11:09:52 +00:00
reecebrowne
a72615cc86
Merge branch 'main' into bug/2490/2488/image-to-pdf
2024-12-18 10:40:54 +00:00
Reece Browne
e9f80d03ea
Fix missing info in form data
2024-12-18 00:16:01 +00:00
Omar Ahmed Hassan
42c238d87d
Pass form to submitMultiPdfForm
...
- Pass form to submitMultiPdfForm to use in FormData creation.
2024-12-18 01:28:04 +02:00
Omar Ahmed Hassan
4998ad064a
Fix form data files being replaced by the last decrypted file
2024-12-17 01:01:15 +02:00
Anthony Stirling
92cabf125e
Merge pull request #2453 from Stirling-Tools/csrf2
...
Csrf fixes
2024-12-14 10:59:50 +00:00
Anthony Stirling
1f1c414138
csrf fixes
2024-12-14 10:42:07 +00:00
Reece Browne
6ee6254f5a
Additional decryption translations
2024-12-06 21:26:28 +00:00
Reece Browne
dcafc0d487
Merge branch 'decrypt' of https://github.com/Stirling-Tools/Stirling-PDF
2024-12-06 15:33:44 +00:00
Anthony Stirling
5a5a8bb7ba
quick fixes ( #2404 )
2024-12-05 19:55:34 +00:00
reecebrowne
526dc9f911
Only download one file on sign cert ( #2397 )
2024-12-05 15:58:27 +00:00
Rafael Encinas
543ad083a2
Fix file clear for errors ( #2302 )
...
* Prevent file input from being removed when an error occurs
* Fix a bug preventing fetch when 'Bored waiting' btn isn't present
2024-11-22 17:11:23 +00:00
alonsofabila-dev and Anthony Stirling
bd29dd1ac3
Bored waiting button doesnt remove itself after processing ( #2079 ) ( #2235 )
...
Fix: Bored waiting button doesnt remove itself after processing (#2079 )
hide bored waiting? button after request handling both success and error cases to properly hide the button.
Co-authored-by: Anthony Stirling <[email protected] >
2024-11-22 09:14:26 +00:00
Anthony Stirling
68349c4426
Update downloader.js
2024-11-21 11:47:47 +00:00
Anthony Stirling
d0d6a70250
Metrics changes ( #2273 )
...
* Update downloader.js
* Update downloader.js
* Update common.html
* Update downloader.js
2024-11-20 10:32:44 +00:00
Rafael Encinas
e059caa14e
Fix id typo for "cropPdfCanvas" querySelector ( #2271 )
...
Fix id typo
2024-11-20 07:53:14 +00:00
Rafael Encinas
1833d7cd73
Clear file inputs after jobs ( #2248 )
2024-11-15 20:21:23 +00:00
Ludy
cf13803fd4
Fix: redeclaration of const and add: tranlation placeholder for Session Expiry Messages ( #2158 )
...
Fix: redeclaration of const
2024-11-03 07:24:16 +00:00
Anthony Stirling
c85463bc18
Frooodle/license ( #1994 )
2024-10-14 22:34:41 +01:00
Dinesh Sharma
765289c89e
Fixed reduce extra space between input field & button #1829 ( #1848 )
...
* Add <br> when Bored Waiting Button Appears
* Added <br> below progress bar as well
* Removed <br>
Two <br> tags were added which were taking lot of space. I dynamically added space when needed.
2024-09-08 19:08:21 +00:00
Anthony Stirling and a
382edc01f8
Multiple flag fix ( #1742 )
...
* fix
* multiple file logic cleanup
* fix
---------
Co-authored-by: a <a>
2024-08-23 09:17:50 +01:00
Anthony Stirling
75e10efcbd
auto decrypt, update discord, fix multi file support for some inputs
2024-07-07 22:49:21 +01:00
Ludy
67a1529dc7
Change to html5 ( #958 )
...
* Change to html5
with Nu Html Checker
* Update scale-pages.html
* Update sign.html
* Update common.html
* Update common.html
* Update login.html
2024-03-21 20:58:01 +00:00
Anthony Stirling
c96ebccae4
Download message for game
2024-02-18 13:30:56 +00:00
Ludy
51ad741744
Fix 746 ( #825 )
...
* Fix : #746
* formatting
2024-02-18 07:40:30 +00:00
Anthony Stirling
673f005fe6
Game fixes and ocr docs ( #824 )
2024-02-17 23:23:07 +00:00
Ludy
e4a76e96af
HTML, CSS, JS and JAVA corrections ( #810 )
...
* CSS corrections
* HTML corrections
* JS corrections
* JAVA corrections
* remove tab
* CSS corrections 2
* JS corrections 2
* back to the roots
* max-linie 127
* add slash hr|br
* return bootstrap-icons.css
* return bootstrap-icons.min.css
* return bootstrap.min.css
* Update bootstrap-icons.css
* Update bootstrap-icons.min.css
* Update bootstrap-icons.min.css
* Update bootstrap.min.css
* CSS corrections
* HTML corrections
* JS corrections
* JAVA corrections
* remove tab
* CSS corrections 2
* JS corrections 2
* back to the roots
* max-linie 127
* add slash hr|br
* return bootstrap-icons.css
* Update bootstrap-icons.css
* Bootstrap CSS
* Update prism.css
2024-02-16 21:49:06 +00:00
sbplat
55d4fda01b
refactor: normalize files
2024-02-11 11:47:00 -05:00
Anthony Stirling
f98f089d63
More fixes for RequestPart mixing
2023-07-30 11:39:29 +01:00
Anthony Stirling
6b618f3abe
Watermark fixes
2023-07-30 11:31:46 +01:00
Anthony Stirling
33a6a7869c
Further Fixes
2023-07-26 22:08:19 +01:00
Anthony Stirling
7b4a889ea7
Remove debugs
2023-06-10 18:14:34 +01:00
Anthony Stirling
67448498ea
documentation stuff and downloer fix for image to pdf
2023-06-10 00:46:44 +01:00
Anthony Stirling
04032c0dfe
sign changes min size, lite docker, merge fix #172
2023-06-08 20:25:55 +01:00
Anthony Stirling
4f851156b7
dummy lang changes
2023-06-04 22:40:14 +01:00
Anthony Stirling
c526e18992
Split pages support n function and other stuff
2023-06-03 22:56:15 +01:00
Anthony Stirling
4594765cbd
rearrange support n numbers, downloader.js fixes
2023-06-03 17:21:59 +01:00
Anthony Stirling
45b3e0aa6a
JS and css cleanup
2023-06-02 20:15:10 +01:00