Enforce type checking in CI (#4126)

# Description of Changes
Currently, the `tsconfig.json` file enforces strict type checking, but
nothing in CI checks that the code is actually correctly typed. [Vite
only transpiles TypeScript
code](https://vite.dev/guide/features.html#transpile-only) so doesn't
ensure that the TS code we're running is correct.

This PR adds running of the type checker to CI and fixes the type errors
that have already crept into the codebase.

Note that many of the changes I've made to 'fix the types' are just
using `any` to disable the type checker because the code is under too
much churn to fix anything properly at the moment. I still think
enabling the type checker now is the best course of action though
because otherwise we'll never be able to fix all of them, and it should
at least help us not break things when adding new code.

Co-authored-by: James <[email protected]>

frontend/src/types/fileContext.ts

@@ -5,7 +5,11 @@
 import { ProcessedFile } from './processing';
 import { PDFDocument, PDFPage, PageOperation } from './pageEditor';
 
-export type ModeType = 'viewer' | 'pageEditor' | 'fileEditor' | 'merge' | 'split' | 'compress' | 'ocr';
+export type ModeType = 'viewer' | 'pageEditor' | 'fileEditor' | 'merge' | 'split' | 'compress' | 'ocr' | 'convert' | 'sanitize';
+
+export type ViewType = 'viewer' | 'pageEditor' | 'fileEditor';
+
+export type ToolType = 'merge' | 'split' | 'compress' | 'ocr' | 'convert' | 'sanitize';
 
 export type OperationType = 'merge' | 'split' | 'compress' | 'add' | 'remove' | 'replace' | 'convert' | 'upload' | 'ocr';
 
@@ -51,25 +55,27 @@ export interface FileContextState {
   // Core file management
   activeFiles: File[];
   processedFiles: Map<File, ProcessedFile>;
-  
+
   // Current navigation state
   currentMode: ModeType;
-  
+  currentView: ViewType;
+  currentTool: ToolType | null;
+
   // Edit history and state
   fileEditHistory: Map<string, FileEditHistory>;
   globalFileOperations: FileOperation[];
   // New comprehensive operation history
   fileOperationHistory: Map<string, FileOperationHistory>;
-  
+
   // UI state that persists across views
   selectedFileIds: string[];
   selectedPageNumbers: number[];
   viewerConfig: ViewerConfig;
-  
+
   // Processing state
   isProcessing: boolean;
   processingProgress: number;
-  
+
   // Export state
   lastExportConfig?: {
     filename: string;
@@ -85,24 +91,26 @@ export interface FileContextState {
 
 export interface FileContextActions {
   // File management
-  addFiles: (files: File[]) => Promise<void>;
+  addFiles: (files: File[]) => Promise<File[]>;
   removeFiles: (fileIds: string[], deleteFromStorage?: boolean) => void;
   replaceFile: (oldFileId: string, newFile: File) => Promise<void>;
   clearAllFiles: () => void;
-  
+
   // Navigation
   setCurrentMode: (mode: ModeType) => void;
+  setCurrentView: (view: ViewType) => void;
+  setCurrentTool: (tool: ToolType) => void;
   // Selection management
   setSelectedFiles: (fileIds: string[]) => void;
   setSelectedPages: (pageNumbers: number[]) => void;
   updateProcessedFile: (file: File, processedFile: ProcessedFile) => void;
   clearSelections: () => void;
-  
+
   // Edit operations
   applyPageOperations: (fileId: string, operations: PageOperation[]) => void;
   applyFileOperation: (operation: FileOperation) => void;
   undoLastOperation: (fileId?: string) => void;
-  
+
   // Operation history management
   recordOperation: (fileId: string, operation: FileOperation | PageOperation) => void;
   markOperationApplied: (fileId: string, operationId: string) => void;
@@ -110,31 +118,31 @@ export interface FileContextActions {
   getFileHistory: (fileId: string) => FileOperationHistory | undefined;
   getAppliedOperations: (fileId: string) => (FileOperation | PageOperation)[];
   clearFileHistory: (fileId: string) => void;
-  
+
   // Viewer state
   updateViewerConfig: (config: Partial<ViewerConfig>) => void;
-  
+
   // Export configuration
   setExportConfig: (config: FileContextState['lastExportConfig']) => void;
-  
-  
+
+
   // Utility
   getFileById: (fileId: string) => File | undefined;
   getProcessedFileById: (fileId: string) => ProcessedFile | undefined;
   getCurrentFile: () => File | undefined;
   getCurrentProcessedFile: () => ProcessedFile | undefined;
-  
+
   // Context persistence
   saveContext: () => Promise<void>;
   loadContext: () => Promise<void>;
   resetContext: () => void;
-  
+
   // Navigation guard system
   setHasUnsavedChanges: (hasChanges: boolean) => void;
   requestNavigation: (navigationFn: () => void) => boolean;
   confirmNavigation: () => void;
   cancelNavigation: () => void;
-  
+
   // Memory management
   trackBlobUrl: (url: string) => void;
   trackPdfDocument: (fileId: string, pdfDoc: any) => void;
@@ -163,4 +171,4 @@ export interface FileContextUrlParams {
   pageIds?: string[];
   zoom?: number;
   page?: number;
-}
+}

frontend/src/types/pageEditor.ts

@@ -13,6 +13,7 @@ export interface PDFDocument {
   file: File;
   pages: PDFPage[];
   totalPages: number;
+  destroy?: () => void;
 }
 
 export interface PageOperation {
@@ -43,7 +44,7 @@ export interface PageEditorFunctions {
   handleRedo: () => void;
   canUndo: boolean;
   canRedo: boolean;
-  handleRotate: () => void;
+  handleRotate: (direction: 'left' | 'right') => void;
   handleDelete: () => void;
   handleSplit: () => void;
   onExportSelected: () => void;

frontend/src/types/tool.ts

@@ -35,6 +35,11 @@ export interface ToolResult {
   metadata?: Record<string, any>;
 }
 
+export interface ToolConfiguration {
+  maxFiles: number;
+  supportedFormats?: string[];
+}
+
 export interface Tool {
   id: string;
   name: string;
@@ -70,4 +75,4 @@ export interface FileSelectionComputed {
   isMultiFileMode: boolean;
 }
 
-export interface FileSelectionContextValue extends FileSelectionState, FileSelectionActions, FileSelectionComputed {}
+export interface FileSelectionContextValue extends FileSelectionState, FileSelectionActions, FileSelectionComputed {}