refactor: replace size checks with isEmpty(), safely collapse redundant emptiness checking logic, minor code improvements (#4132)

app/common/src/main/java/stirling/software/common/model/ApplicationProperties.java

@@ -452,19 +452,17 @@ public class ApplicationProperties {
         private List<String> languages;
 
         public String getAppName() {
-            return appName != null && appName.trim().length() > 0 ? appName : null;
+            return appName != null && !appName.trim().isEmpty() ? appName : null;
         }
 
         public String getHomeDescription() {
-            return homeDescription != null && homeDescription.trim().length() > 0
+            return homeDescription != null && !homeDescription.trim().isEmpty()
                     ? homeDescription
                     : null;
         }
 
         public String getAppNameNavbar() {
-            return appNameNavbar != null && appNameNavbar.trim().length() > 0
-                    ? appNameNavbar
-                    : null;
+            return appNameNavbar != null && !appNameNavbar.trim().isEmpty() ? appNameNavbar : null;
         }
     }
 

app/common/src/main/java/stirling/software/common/util/CustomHtmlSanitizer.java

@@ -26,7 +26,7 @@ public class CustomHtmlSanitizer {
             new AttributePolicy() {
                 @Override
                 public String apply(String elementName, String attributeName, String value) {
-                    if (value == null || value.trim().isEmpty()) {
+                    if (value.trim().isEmpty()) {
                         return null;
                     }
 

app/common/src/main/java/stirling/software/common/util/PDFToFile.java

@@ -74,7 +74,7 @@ public class PDFToFile {
         Path tempInputFile = null;
         Path tempOutputDir = null;
         byte[] fileBytes;
-        String fileName = "temp.file";
+        String fileName;
 
         try {
             tempInputFile = Files.createTempFile("input_", ".pdf");
@@ -167,7 +167,7 @@ public class PDFToFile {
         Path tempInputFile = null;
         Path tempOutputDir = null;
         byte[] fileBytes;
-        String fileName = "temp.file";
+        String fileName;
 
         try {
             // Save the uploaded file to a temporary location
@@ -230,7 +230,7 @@ public class PDFToFile {
         // Get the original PDF file name without the extension
         String originalPdfFileName = Filenames.toSimpleFileName(inputFile.getOriginalFilename());
 
-        if (originalPdfFileName == null || "".equals(originalPdfFileName.trim())) {
+        if (originalPdfFileName == null || originalPdfFileName.trim().isEmpty()) {
             originalPdfFileName = "output.pdf";
         }
         // Assume file is pdf if no extension
@@ -248,7 +248,7 @@ public class PDFToFile {
         Path tempInputFile = null;
         Path tempOutputDir = null;
         byte[] fileBytes;
-        String fileName = "temp.file";
+        String fileName;
 
         try {
             // Save the uploaded file to a temporary location

app/common/src/main/java/stirling/software/common/util/PdfUtils.java

@@ -131,7 +131,7 @@ public class PdfUtils {
     }
 
     public boolean hasImagesOnPage(PDPage page) throws IOException {
-        return getAllImages(page.getResources()).size() > 0;
+        return !getAllImages(page.getResources()).isEmpty();
     }
 
     public boolean hasTextOnPage(PDPage page, String phrase) throws IOException {