From ac231e0c9274bfe21924928e4facbcb83b3833b7 Mon Sep 17 00:00:00 2001 From: ConnorYoh <40631091+ConnorYoh@users.noreply.github.com> Date: Mon, 14 Apr 2025 10:44:28 +0100 Subject: [PATCH] 3335 feature request add app version to posthog (#3348) # Description of Changes Please provide a summary of the changes, including: Added app_version to all posthog captures Closes #(3335) --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details. --- .../stirling/software/SPDF/service/PostHogService.java | 2 ++ src/main/resources/templates/fragments/common.html | 7 +++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/stirling/software/SPDF/service/PostHogService.java b/src/main/java/stirling/software/SPDF/service/PostHogService.java index 29d0a6f61..51faba5be 100644 --- a/src/main/java/stirling/software/SPDF/service/PostHogService.java +++ b/src/main/java/stirling/software/SPDF/service/PostHogService.java @@ -63,6 +63,8 @@ public class PostHogService { if (!applicationProperties.getSystem().isAnalyticsEnabled()) { return; } + + properties.put("app_version", appVersion); postHog.capture(uniqueId, eventName, properties); } diff --git a/src/main/resources/templates/fragments/common.html b/src/main/resources/templates/fragments/common.html index 6ba5e710b..b82114815 100644 --- a/src/main/resources/templates/fragments/common.html +++ b/src/main/resources/templates/fragments/common.html @@ -84,13 +84,11 @@ function UpdatePosthogConsent(){ if(typeof(posthog) == "undefined") { - console.log("Posthog not initialised"); return; } window.CookieConsent.acceptedCategory('analytics')? posthog.opt_in_capturing() : posthog.opt_out_capturing(); - console.log("Posthog: Opted " + (posthog.has_opted_out_capturing()? "out" : "in")); } const stirlingPDFLabel = /*[[${@StirlingPDFLabel}]]*/ ''; const analyticsEnabled = /*[[${@analyticsEnabled}]]*/ false; @@ -150,8 +148,9 @@ const baseUrl = window.location.hostname; posthog.register_once({ 'hostname': baseUrl, - 'UUID': /*[[${@UUID}]]*/ '' - }) + 'UUID': /*[[${@UUID}]]*/ '', + 'app_version': /*[[${@appVersion}]]*/ '', + }); } window.addEventListener("cc:onConsent", UpdatePosthogConsent);