mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-15 19:10:47 +02:00
Prettier 2: Electric Boogaloo (#6113)
# Description of Changes When I added Prettier formatting in #6052, my aim was to use just the default settings in Prettier. Turns out, Prettier looks _really hard_ for any config files if it's not explicitly given one, which means that if a developer has some sort of Prettier config file lying around on their system, Prettier might find it and use it. Also, Prettier changes its defaults based on stuff in `.editorconfig` without any good way of disabling that behaviour explicitly in its config file. To solve both of these issues, I've introduced a `.prettierrc` file which sets Prettier's defaults explicitly, and then reformatted all our code _again_ in Prettier's actual default settings. This should achieve the aim of #6052 and remove the possibility for it breaking on different dev computers.
This commit is contained in:
@@ -20,7 +20,9 @@ const args = process.argv.slice(2);
|
||||
const isDesktop = args.includes("--desktop");
|
||||
const isSaas = args.includes("--saas");
|
||||
|
||||
console.log("setup-env: see frontend/README.md#environment-variables for documentation");
|
||||
console.log(
|
||||
"setup-env: see frontend/README.md#environment-variables for documentation",
|
||||
);
|
||||
|
||||
function getExampleKeys(exampleFile: string): string[] {
|
||||
const examplePath = join(root, exampleFile);
|
||||
@@ -44,7 +46,9 @@ function ensureEnvFile(envFile: string, exampleFile: string): boolean {
|
||||
|
||||
config({ path: envPath });
|
||||
|
||||
const missing = getExampleKeys(exampleFile).filter((k) => !(k in process.env));
|
||||
const missing = getExampleKeys(exampleFile).filter(
|
||||
(k) => !(k in process.env),
|
||||
);
|
||||
|
||||
if (missing.length > 0) {
|
||||
console.error(
|
||||
@@ -62,7 +66,8 @@ let failed = false;
|
||||
failed = ensureEnvFile(".env", "config/.env.example") || failed;
|
||||
|
||||
if (isDesktop) {
|
||||
failed = ensureEnvFile(".env.desktop", "config/.env.desktop.example") || failed;
|
||||
failed =
|
||||
ensureEnvFile(".env.desktop", "config/.env.desktop.example") || failed;
|
||||
}
|
||||
|
||||
if (isSaas) {
|
||||
@@ -75,7 +80,9 @@ const allExampleKeys = new Set([
|
||||
...getExampleKeys("config/.env.desktop.example"),
|
||||
...getExampleKeys("config/.env.saas.example"),
|
||||
]);
|
||||
const unknownViteVars = Object.keys(process.env).filter((k) => k.startsWith("VITE_") && !allExampleKeys.has(k));
|
||||
const unknownViteVars = Object.keys(process.env).filter(
|
||||
(k) => k.startsWith("VITE_") && !allExampleKeys.has(k),
|
||||
);
|
||||
if (unknownViteVars.length > 0) {
|
||||
console.warn(
|
||||
"setup-env: the following VITE_ vars are set but not listed in any example file:\n" +
|
||||
|
||||
Reference in New Issue
Block a user