mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-15 11:00:47 +02:00
Lazy-load Stripe SDK so it only loads on checkout (#6546)
# Description of Changes - Stripe SDK (`@stripe/*` + `js.stripe.com/v3`) was loading on every page; now it only loads when an upgrade/checkout modal actually opens. - Converted every import site to `React.lazy()` + `<Suspense>`, gated by the existing `opened` state. - Adds a Playwright spec that asserts no Stripe requests on landing or settings. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have run `task check` to verify linters, typechecks, and tests pass - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#7-testing) for more details.
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
import { test, expect } from "@app/tests/helpers/stub-test-base";
|
||||
|
||||
/**
|
||||
* Verifies that the Stripe SDK (@stripe/stripe-js, @stripe/react-stripe-js,
|
||||
* and the js.stripe.com remote script) is NOT fetched on cold page loads —
|
||||
* only when the checkout modal actually mounts. The proprietary
|
||||
* CheckoutProvider, the SaaS TrialStatusBanner, and the SaaS Plan settings
|
||||
* page all gate the modal behind React.lazy + a conditional render so the
|
||||
* Stripe chunk lives in its own async bundle.
|
||||
*/
|
||||
|
||||
const STRIPE_URL_FRAGMENTS = [
|
||||
"js.stripe.com",
|
||||
"@stripe/stripe-js",
|
||||
// Vite's optimizeDeps id mangles slashes to underscores when serving
|
||||
// pre-bundled dependencies from node_modules/.vite/deps.
|
||||
"@stripe_stripe-js",
|
||||
"@stripe/react-stripe-js",
|
||||
"@stripe_react-stripe-js",
|
||||
];
|
||||
|
||||
function isStripeRequest(url: string): boolean {
|
||||
return STRIPE_URL_FRAGMENTS.some((fragment) => url.includes(fragment));
|
||||
}
|
||||
|
||||
test.describe("Stripe SDK lazy loading", () => {
|
||||
test("landing page does not fetch Stripe SDK on cold load", async ({
|
||||
page,
|
||||
}) => {
|
||||
const stripeRequests: string[] = [];
|
||||
page.on("request", (req) => {
|
||||
const url = req.url();
|
||||
if (isStripeRequest(url)) {
|
||||
stripeRequests.push(url);
|
||||
}
|
||||
});
|
||||
|
||||
// The stub fixture already navigated to "/" with waitUntil:
|
||||
// domcontentloaded. Wait for the app to actually settle so any lurking
|
||||
// module-eval-time loadStripe() call would have already kicked off.
|
||||
await page
|
||||
.waitForLoadState("networkidle", { timeout: 15_000 })
|
||||
.catch(() => {
|
||||
// Posthog / iconify keep some connections warm — fall back to a
|
||||
// brief settle window if networkidle never resolves.
|
||||
});
|
||||
await page.waitForTimeout(2_000);
|
||||
|
||||
expect(
|
||||
stripeRequests,
|
||||
`Expected no Stripe-related network activity on landing, but observed:\n${stripeRequests.join("\n")}`,
|
||||
).toEqual([]);
|
||||
});
|
||||
|
||||
test("settings modal does not fetch Stripe SDK", async ({ page }) => {
|
||||
const stripeRequests: string[] = [];
|
||||
page.on("request", (req) => {
|
||||
const url = req.url();
|
||||
if (isStripeRequest(url)) {
|
||||
stripeRequests.push(url);
|
||||
}
|
||||
});
|
||||
|
||||
// Opening Settings is the closest a default proprietary user gets to
|
||||
// checkout without actually clicking Upgrade. Even rendering the
|
||||
// settings drawer must NOT pull Stripe into the entry path — only the
|
||||
// upgrade modal itself, which sits one click further in.
|
||||
const settingsButton = page
|
||||
.getByRole("button", { name: /settings/i })
|
||||
.first();
|
||||
if (await settingsButton.isVisible({ timeout: 5_000 }).catch(() => false)) {
|
||||
await settingsButton.click();
|
||||
await page.waitForTimeout(1_500);
|
||||
}
|
||||
|
||||
expect(
|
||||
stripeRequests,
|
||||
`Expected no Stripe-related network activity after opening settings, but observed:\n${stripeRequests.join("\n")}`,
|
||||
).toEqual([]);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user