mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-14 10:34:06 +02:00
Change frontend .env files to be committed and have .env.*.local overrides (#6207)
This commit is contained in:
+3
-3
@@ -163,9 +163,6 @@ __pycache__/
|
|||||||
*.pyo
|
*.pyo
|
||||||
|
|
||||||
# Virtual environments
|
# Virtual environments
|
||||||
.env*
|
|
||||||
!.env*.example
|
|
||||||
!engine/.env
|
|
||||||
.venv*
|
.venv*
|
||||||
env*/
|
env*/
|
||||||
venv*/
|
venv*/
|
||||||
@@ -173,6 +170,9 @@ ENV/
|
|||||||
env.bak/
|
env.bak/
|
||||||
venv.bak/
|
venv.bak/
|
||||||
|
|
||||||
|
# Env files (secrets / local overrides). Subproject .gitignore files whitelist any committed defaults.
|
||||||
|
.env*
|
||||||
|
|
||||||
# VS Code
|
# VS Code
|
||||||
/.vscode/**/*
|
/.vscode/**/*
|
||||||
!/.vscode/settings.json
|
!/.vscode/settings.json
|
||||||
|
|||||||
+5
-10
@@ -22,9 +22,8 @@ tasks:
|
|||||||
- npx tsx scripts/setup-env.ts
|
- npx tsx scripts/setup-env.ts
|
||||||
sources:
|
sources:
|
||||||
- scripts/setup-env.ts
|
- scripts/setup-env.ts
|
||||||
- config/.env.example
|
|
||||||
generates:
|
generates:
|
||||||
- .env
|
- .env.local
|
||||||
|
|
||||||
prepare:env:saas:
|
prepare:env:saas:
|
||||||
desc: "Generate .env and .env.saas from examples if missing"
|
desc: "Generate .env and .env.saas from examples if missing"
|
||||||
@@ -34,11 +33,9 @@ tasks:
|
|||||||
- npx tsx scripts/setup-env.ts --saas
|
- npx tsx scripts/setup-env.ts --saas
|
||||||
sources:
|
sources:
|
||||||
- scripts/setup-env.ts
|
- scripts/setup-env.ts
|
||||||
- config/.env.example
|
|
||||||
- config/.env.saas.example
|
|
||||||
generates:
|
generates:
|
||||||
- .env
|
- .env.local
|
||||||
- .env.saas
|
- .env.saas.local
|
||||||
|
|
||||||
prepare:env:desktop:
|
prepare:env:desktop:
|
||||||
desc: "Generate .env and .env.desktop from examples if missing"
|
desc: "Generate .env and .env.desktop from examples if missing"
|
||||||
@@ -48,11 +45,9 @@ tasks:
|
|||||||
- npx tsx scripts/setup-env.ts --desktop
|
- npx tsx scripts/setup-env.ts --desktop
|
||||||
sources:
|
sources:
|
||||||
- scripts/setup-env.ts
|
- scripts/setup-env.ts
|
||||||
- config/.env.example
|
|
||||||
- config/.env.desktop.example
|
|
||||||
generates:
|
generates:
|
||||||
- .env
|
- .env.local
|
||||||
- .env.desktop
|
- .env.desktop.local
|
||||||
|
|
||||||
prepare:icons:
|
prepare:icons:
|
||||||
desc: "Generate icon bundle from source references"
|
desc: "Generate icon bundle from source references"
|
||||||
|
|||||||
@@ -136,12 +136,14 @@ The project structure is defined in `engine/pyproject.toml`. Any new dependencie
|
|||||||
- **Development**: `task desktop:dev` for desktop dev mode
|
- **Development**: `task desktop:dev` for desktop dev mode
|
||||||
|
|
||||||
#### Environment Variables
|
#### Environment Variables
|
||||||
- All `VITE_*` variables must be declared in the appropriate example file:
|
- All `VITE_*` variables must be declared in the appropriate committed env file:
|
||||||
- `frontend/config/.env.example` — core, proprietary, and shared vars
|
- `frontend/.env` — core, proprietary, and shared vars
|
||||||
- `frontend/config/.env.saas.example` — SaaS-only vars
|
- `frontend/.env.saas` — SaaS-only vars (layered on top of `.env` in SaaS mode)
|
||||||
- `frontend/config/.env.desktop.example` — desktop (Tauri)-only vars
|
- `frontend/.env.desktop` — desktop (Tauri)-only vars (layered on top of `.env` in desktop mode)
|
||||||
- Never use `|| 'hardcoded-fallback'` inline — put defaults in the example files
|
- These files are committed to Git and must not contain private keys
|
||||||
- `task frontend:prepare` / `prepare:saas` / `prepare:desktop` auto-create the env files from examples on first run, and error if any required keys are missing
|
- Local overrides (API keys, machine-specific settings) go in uncommitted sibling `.env.local` / `.env.saas.local` / `.env.desktop.local` files — Vite automatically layers them on top
|
||||||
|
- Never use `|| 'hardcoded-fallback'` inline — put defaults in the committed env files
|
||||||
|
- `task frontend:prepare` / `prepare:saas` / `prepare:desktop` create empty `.local` override files on first run
|
||||||
- Prepare runs automatically as a dependency of all `dev*`, `build*`, and `desktop*` tasks
|
- Prepare runs automatically as a dependency of all `dev*`, `build*`, and `desktop*` tasks
|
||||||
- See `frontend/README.md#environment-variables` for full documentation
|
- See `frontend/README.md#environment-variables` for full documentation
|
||||||
|
|
||||||
|
|||||||
@@ -21,6 +21,9 @@ yarn-error.log*
|
|||||||
# Environment
|
# Environment
|
||||||
.env.local
|
.env.local
|
||||||
|
|
||||||
|
# Root .gitignore ignores all .env* - whitelist our committed .env here
|
||||||
|
!.env
|
||||||
|
|
||||||
# LaTeX outputs
|
# LaTeX outputs
|
||||||
*.aux
|
*.aux
|
||||||
*.log
|
*.log
|
||||||
|
|||||||
@@ -1,4 +1,8 @@
|
|||||||
|
###############################################################################
|
||||||
# Frontend environment variables for core and proprietary builds.
|
# Frontend environment variables for core and proprietary builds.
|
||||||
|
# Values can be overridden in the uncommitted sibling `.env.local` file.
|
||||||
|
# Note: This file is committed to Git, so should not contain any private keys.
|
||||||
|
###############################################################################
|
||||||
|
|
||||||
# API base URL — use / for same-origin (default for web builds)
|
# API base URL — use / for same-origin (default for web builds)
|
||||||
VITE_API_BASE_URL=/
|
VITE_API_BASE_URL=/
|
||||||
@@ -1,5 +1,9 @@
|
|||||||
|
###############################################################################
|
||||||
# Frontend environment variables for desktop (Tauri) builds.
|
# Frontend environment variables for desktop (Tauri) builds.
|
||||||
# Layered on top of .env when running in desktop mode.
|
# Layered on top of .env when running in desktop mode.
|
||||||
|
# Values can be overridden in the uncommitted sibling `.env.desktop.local` file.
|
||||||
|
# Note: This file is committed to Git, so should not contain any private keys.
|
||||||
|
###############################################################################
|
||||||
|
|
||||||
# Desktop backend endpoint — leave blank to use VITE_API_BASE_URL from .env
|
# Desktop backend endpoint — leave blank to use VITE_API_BASE_URL from .env
|
||||||
VITE_DESKTOP_BACKEND_URL=
|
VITE_DESKTOP_BACKEND_URL=
|
||||||
@@ -1,5 +1,9 @@
|
|||||||
|
###############################################################################
|
||||||
# Frontend environment variables for SaaS builds.
|
# Frontend environment variables for SaaS builds.
|
||||||
# Layered on top of .env when running in SaaS mode.
|
# Layered on top of .env when running in SaaS mode.
|
||||||
|
# Values can be overridden in the uncommitted sibling `.env.saas.local` file.
|
||||||
|
# Note: This file is committed to Git, so should not contain any private keys.
|
||||||
|
###############################################################################
|
||||||
|
|
||||||
# Userback feedback widget — leave blank to disable
|
# Userback feedback widget — leave blank to disable
|
||||||
VITE_USERBACK_TOKEN=
|
VITE_USERBACK_TOKEN=
|
||||||
+6
-7
@@ -14,14 +14,13 @@
|
|||||||
|
|
||||||
# misc
|
# misc
|
||||||
.DS_Store
|
.DS_Store
|
||||||
.env
|
|
||||||
.env.saas
|
|
||||||
.env.desktop
|
|
||||||
.env.local
|
.env.local
|
||||||
.env.development.local
|
.env.*.local
|
||||||
.env.test.local
|
|
||||||
.env.production.local
|
# Root .gitignore ignores all .env* - whitelist our committed ones here
|
||||||
!.env*.example
|
!.env
|
||||||
|
!.env.desktop
|
||||||
|
!.env.saas
|
||||||
|
|
||||||
npm-debug.log*
|
npm-debug.log*
|
||||||
yarn-debug.log*
|
yarn-debug.log*
|
||||||
|
|||||||
+7
-8
@@ -15,11 +15,15 @@ For desktop app development, see the [Tauri](#tauri) section below.
|
|||||||
|
|
||||||
## Environment Variables
|
## Environment Variables
|
||||||
|
|
||||||
The frontend requires environment variables to be set before running. `task frontend:dev` will create a `.env` file for you automatically on first run using the defaults from `config/.env.example` - for most development work this is all you need.
|
Environment variables live in committed `.env` files at the frontend root:
|
||||||
|
|
||||||
If you need to configure specific services (Google Drive, Supabase, Stripe, PostHog), edit your local `.env` file. The values in `config/.env.example` show what each variable does and provides sensible defaults where applicable.
|
- `.env` — used by all builds (core, proprietary, and as the base for desktop/SaaS)
|
||||||
|
- `.env.desktop` — additional vars loaded in desktop (Tauri) mode
|
||||||
|
- `.env.saas` — additional vars loaded in SaaS mode
|
||||||
|
|
||||||
For desktop (Tauri) development, `task desktop:dev` will additionally create a `.env.desktop` file from `config/.env.desktop.example`.
|
These files contain non-secret defaults and are checked into Git, so most dev work needs no further setup.
|
||||||
|
|
||||||
|
To override values locally (API keys, machine-specific settings), create an uncommitted sibling `.env.local` / `.env.desktop.local` / `.env.saas.local`. Vite automatically layers these on top of the committed files.
|
||||||
|
|
||||||
## Docker Setup
|
## Docker Setup
|
||||||
|
|
||||||
@@ -72,8 +76,3 @@ task desktop:clean
|
|||||||
```
|
```
|
||||||
|
|
||||||
Removes all desktop build artifacts including JLink runtime, bundled JARs, Cargo build, and dist/build directories.
|
Removes all desktop build artifacts including JLink runtime, bundled JARs, Cargo build, and dist/build directories.
|
||||||
|
|
||||||
> [!NOTE]
|
|
||||||
>
|
|
||||||
> Desktop builds require additional environment variables. See [Environment Variables](#environment-variables)
|
|
||||||
> above - `task desktop:dev` will set these up automatically from `config/.env.desktop.example` on first run.
|
|
||||||
|
|||||||
@@ -1,18 +1,18 @@
|
|||||||
/**
|
/**
|
||||||
* Copies missing env files from their .example templates, and warns about
|
* Ensures `.env.local` (and mode-specific `.env.desktop.local` / `.env.saas.local`)
|
||||||
* any keys present in the example but not set in the environment.
|
* files exist so developers have a place to put overrides (API keys, machine-specific
|
||||||
* Also warns about any VITE_ vars set in the environment that aren't listed
|
* settings) without touching the committed `.env` / `.env.desktop` / `.env.saas` files.
|
||||||
* in any example file.
|
*
|
||||||
|
* Vite automatically layers these `.local` files on top of the committed ones.
|
||||||
*
|
*
|
||||||
* Usage:
|
* Usage:
|
||||||
* tsx scripts/setup-env.ts # checks .env
|
* tsx scripts/setup-env.ts # ensures .env.local
|
||||||
* tsx scripts/setup-env.ts --desktop # also checks .env.desktop
|
* tsx scripts/setup-env.ts --desktop # also ensures .env.desktop.local
|
||||||
* tsx scripts/setup-env.ts --saas # also checks .env.saas
|
* tsx scripts/setup-env.ts --saas # also ensures .env.saas.local
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { existsSync, copyFileSync, readFileSync } from "fs";
|
import { existsSync, writeFileSync } from "fs";
|
||||||
import { join } from "path";
|
import { join } from "path";
|
||||||
import { config, parse } from "dotenv";
|
|
||||||
|
|
||||||
// npm scripts run from the directory containing package.json (frontend/)
|
// npm scripts run from the directory containing package.json (frontend/)
|
||||||
const root = process.cwd();
|
const root = process.cwd();
|
||||||
@@ -20,75 +20,25 @@ const args = process.argv.slice(2);
|
|||||||
const isDesktop = args.includes("--desktop");
|
const isDesktop = args.includes("--desktop");
|
||||||
const isSaas = args.includes("--saas");
|
const isSaas = args.includes("--saas");
|
||||||
|
|
||||||
console.log(
|
function template(parent: string): string {
|
||||||
"setup-env: see frontend/README.md#environment-variables for documentation",
|
return [
|
||||||
);
|
"###############################################################################",
|
||||||
|
`# Local overrides for \`frontend/${parent}\``,
|
||||||
function getExampleKeys(exampleFile: string): string[] {
|
"# Put API keys and machine-specific settings here. Any variable defined here",
|
||||||
const examplePath = join(root, exampleFile);
|
`# takes precedence over the committed \`${parent}\``,
|
||||||
if (!existsSync(examplePath)) return [];
|
"###############################################################################",
|
||||||
return Object.keys(parse(readFileSync(examplePath, "utf-8")));
|
"",
|
||||||
|
].join("\n");
|
||||||
}
|
}
|
||||||
|
|
||||||
function ensureEnvFile(envFile: string, exampleFile: string): boolean {
|
function ensureLocalFile(localFile: string, parentFile: string): void {
|
||||||
const envPath = join(root, envFile);
|
const localPath = join(root, localFile);
|
||||||
const examplePath = join(root, exampleFile);
|
if (!existsSync(localPath)) {
|
||||||
|
writeFileSync(localPath, template(parentFile));
|
||||||
if (!existsSync(examplePath)) {
|
console.log(`setup-env: created empty ${localFile} for local overrides`);
|
||||||
console.warn(`setup-env: ${exampleFile} not found, skipping ${envFile}`);
|
}
|
||||||
return false;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!existsSync(envPath)) {
|
ensureLocalFile(".env.local", ".env");
|
||||||
copyFileSync(examplePath, envPath);
|
if (isDesktop) ensureLocalFile(".env.desktop.local", ".env.desktop");
|
||||||
console.log(`setup-env: created ${envFile} from ${exampleFile}`);
|
if (isSaas) ensureLocalFile(".env.saas.local", ".env.saas");
|
||||||
}
|
|
||||||
|
|
||||||
config({ path: envPath });
|
|
||||||
|
|
||||||
const missing = getExampleKeys(exampleFile).filter(
|
|
||||||
(k) => !(k in process.env),
|
|
||||||
);
|
|
||||||
|
|
||||||
if (missing.length > 0) {
|
|
||||||
console.error(
|
|
||||||
`setup-env: ${envFile} is missing keys from ${exampleFile}:\n` +
|
|
||||||
missing.map((k) => ` ${k}`).join("\n") +
|
|
||||||
"\n Add them manually or delete your local file to re-copy from the example.",
|
|
||||||
);
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
let failed = false;
|
|
||||||
failed = ensureEnvFile(".env", "config/.env.example") || failed;
|
|
||||||
|
|
||||||
if (isDesktop) {
|
|
||||||
failed =
|
|
||||||
ensureEnvFile(".env.desktop", "config/.env.desktop.example") || failed;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (isSaas) {
|
|
||||||
failed = ensureEnvFile(".env.saas", "config/.env.saas.example") || failed;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Warn about any VITE_ vars set in the environment that aren't listed in any example file.
|
|
||||||
const allExampleKeys = new Set([
|
|
||||||
...getExampleKeys("config/.env.example"),
|
|
||||||
...getExampleKeys("config/.env.desktop.example"),
|
|
||||||
...getExampleKeys("config/.env.saas.example"),
|
|
||||||
]);
|
|
||||||
const unknownViteVars = Object.keys(process.env).filter(
|
|
||||||
(k) => k.startsWith("VITE_") && !allExampleKeys.has(k),
|
|
||||||
);
|
|
||||||
if (unknownViteVars.length > 0) {
|
|
||||||
console.warn(
|
|
||||||
"setup-env: the following VITE_ vars are set but not listed in any example file:\n" +
|
|
||||||
unknownViteVars.map((k) => ` ${k}`).join("\n") +
|
|
||||||
"\n Add them to the appropriate config/.env.*.example file if they are required.",
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (failed) process.exit(1);
|
|
||||||
|
|||||||
@@ -49,30 +49,24 @@ function findViteEnvVars(srcDir: string): Set<string> {
|
|||||||
|
|
||||||
describe("env vars", () => {
|
describe("env vars", () => {
|
||||||
it("every VITE_ var used in source is present in an example env file", () => {
|
it("every VITE_ var used in source is present in an example env file", () => {
|
||||||
const baseEnv = readFileSync(
|
const baseEnv = readFileSync(join(frontendRoot, ".env"), "utf-8");
|
||||||
join(frontendRoot, "config/.env.example"),
|
|
||||||
"utf-8",
|
|
||||||
);
|
|
||||||
const desktopEnv = readFileSync(
|
const desktopEnv = readFileSync(
|
||||||
join(frontendRoot, "config/.env.desktop.example"),
|
join(frontendRoot, ".env.desktop"),
|
||||||
"utf-8",
|
|
||||||
);
|
|
||||||
const saasEnv = readFileSync(
|
|
||||||
join(frontendRoot, "config/.env.saas.example"),
|
|
||||||
"utf-8",
|
"utf-8",
|
||||||
);
|
);
|
||||||
|
const saasEnv = readFileSync(join(frontendRoot, ".env.saas"), "utf-8");
|
||||||
|
|
||||||
const exampleKeys = new Set([
|
const declaredKeys = new Set([
|
||||||
...parseEnvKeys(baseEnv),
|
...parseEnvKeys(baseEnv),
|
||||||
...parseEnvKeys(desktopEnv),
|
...parseEnvKeys(desktopEnv),
|
||||||
...parseEnvKeys(saasEnv),
|
...parseEnvKeys(saasEnv),
|
||||||
]);
|
]);
|
||||||
const sourceVars = findViteEnvVars(join(frontendRoot, "src"));
|
const sourceVars = findViteEnvVars(join(frontendRoot, "src"));
|
||||||
|
|
||||||
const missing = [...sourceVars].filter((v) => !exampleKeys.has(v));
|
const missing = [...sourceVars].filter((v) => !declaredKeys.has(v));
|
||||||
expect(
|
expect(
|
||||||
missing,
|
missing,
|
||||||
`Missing from 'frontend/config/.env.example' files: ${missing.join(", ")}`,
|
`Missing from 'frontend/.env*' files: ${missing.join(", ")}`,
|
||||||
).toHaveLength(0);
|
).toHaveLength(0);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user