various cookie banner fixes (#5027)

# Description of Changes

<!--
Please provide a summary of the changes, including:

- What was changed
- Why the change was made
- Any challenges encountered

Closes #(issue_number)
-->

---

## Checklist

### General

- [ ] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [ ] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md)
(if applicable)
- [ ] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md)
(if applicable)
- [ ] I have performed a self-review of my own code
- [ ] My changes generate no new warnings

### Documentation

- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/)
(if functionality has heavily changed)
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags)
(for new translation tags only)

### Translations (if applicable)

- [ ] I ran
[`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md)

### UI Changes (if applicable)

- [ ] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)

### Testing (if applicable)

- [ ] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing)
for more details.

frontend/src/core/components/AppProviders.tsx

@@ -17,7 +17,6 @@ import { TourOrchestrationProvider } from "@app/contexts/TourOrchestrationContex
 import { AdminTourOrchestrationProvider } from "@app/contexts/AdminTourOrchestrationContext";
 import { PageEditorProvider } from "@app/contexts/PageEditorContext";
 import { BannerProvider } from "@app/contexts/BannerContext";
-import { CookieConsentProvider } from "@app/contexts/CookieConsentContext";
 import ErrorBoundary from "@app/components/shared/ErrorBoundary";
 import { useScarfTracking } from "@app/hooks/useScarfTracking";
 import { useAppInitialization } from "@app/hooks/useAppInitialization";
@@ -83,12 +82,11 @@ export function AppProviders({ children, appConfigRetryOptions, appConfigProvide
                 retryOptions={appConfigRetryOptions}
                 {...appConfigProviderProps}
               >
-                <CookieConsentProvider>
-                  <ScarfTrackingInitializer />
-                  <FileContextProvider enableUrlSync={true} enablePersistence={true}>
-                    <AppInitializer />
-                    <BrandingAssetManager />
-                    <ToolRegistryProvider>
+                <ScarfTrackingInitializer />
+                <FileContextProvider enableUrlSync={true} enablePersistence={true}>
+                  <AppInitializer />
+                  <BrandingAssetManager />
+                  <ToolRegistryProvider>
                       <NavigationProvider>
                         <FilesModalProvider>
                           <ToolWorkflowProvider>
@@ -114,7 +112,6 @@ export function AppProviders({ children, appConfigRetryOptions, appConfigProvide
                       </NavigationProvider>
                     </ToolRegistryProvider>
                   </FileContextProvider>
-                </CookieConsentProvider>
               </AppConfigProvider>
             </OnboardingProvider>
           </BannerProvider>

frontend/src/core/components/onboarding/hooks/useOnboardingFlow.ts

@@ -1,7 +1,6 @@
 import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { usePreferences } from '@app/contexts/PreferencesContext';
 import { useAppConfig } from '@app/contexts/AppConfigContext';
-import { useCookieConsentContext } from '@app/contexts/CookieConsentContext';
 import { useOnboarding } from '@app/contexts/OnboardingContext';
 import type { LicenseNotice } from '@app/types/types';
 import { useNavigate, useLocation } from 'react-router-dom';
@@ -39,7 +38,6 @@ interface ServerLicenseModalHandlers {
 export function useOnboardingFlow() {
   const { preferences, updatePreference } = usePreferences();
   const { config, loading: configLoading } = useAppConfig();
-  const { showCookieConsent, isReady: isCookieConsentReady } = useCookieConsentContext();
   const { completeTour, tourType, isOpen } = useOnboarding();
   const location = useLocation();
   
@@ -71,7 +69,6 @@ export function useOnboardingFlow() {
     isOverLimit: false,
     requiresLicense: false,
   });
-  const [cookieBannerPending, setCookieBannerPending] = useState(false);
   const [serverLicenseIntent, setServerLicenseIntent] = useState<'idle' | 'pending' | 'deferred'>('idle');
   const [serverLicenseSource, setServerLicenseSource] = useState<'config' | 'self-reported' | null>(null);
   const [isServerLicenseOpen, setIsServerLicenseOpen] = useState(false);
@@ -97,29 +94,6 @@ export function useOnboardingFlow() {
     setToolPromptCompleted(true);
   }, []);
 
-  const maybeShowCookieBanner = useCallback(() => {
-    if (preferences.hasSeenCookieBanner) {
-      return;
-    }
-
-    if (!isCookieConsentReady || isServerLicenseOpen || serverLicenseIntent !== 'idle' || !toolPromptCompleted) {
-      setCookieBannerPending(true);
-      return;
-    }
-
-    setCookieBannerPending(false);
-    showCookieConsent();
-    updatePreference('hasSeenCookieBanner', true);
-  }, [
-    isCookieConsentReady,
-    isServerLicenseOpen,
-    preferences.hasSeenCookieBanner,
-    serverLicenseIntent,
-    showCookieConsent,
-    toolPromptCompleted,
-    updatePreference,
-  ]);
-
   const requestServerLicense = useCallback(
     ({
       deferUntilTourComplete = false,
@@ -191,25 +165,6 @@ export function useOnboardingFlow() {
     };
   }, [requestServerLicense]);
 
-  useEffect(() => {
-    if (
-      cookieBannerPending &&
-      isCookieConsentReady &&
-      serverLicenseIntent === 'idle' &&
-      !isServerLicenseOpen &&
-      toolPromptCompleted
-    ) {
-      maybeShowCookieBanner();
-    }
-  }, [
-    cookieBannerPending,
-    isCookieConsentReady,
-    isServerLicenseOpen,
-    serverLicenseIntent,
-    toolPromptCompleted,
-    maybeShowCookieBanner,
-  ]);
-
   useEffect(() => {
     const isEligibleAdmin =
       isAdminUser || serverLicenseSource === 'self-reported' || licenseNotice.requiresLicense;
@@ -269,8 +224,7 @@ export function useOnboardingFlow() {
     setHasShownServerLicense(true);
     setServerLicenseIntent('idle');
     setServerLicenseSource(null);
-    maybeShowCookieBanner();
-  }, [maybeShowCookieBanner]);
+  }, []);
 
   useEffect(() => {
     if (onboardingSessionMarkedRef.current) {
@@ -309,11 +263,9 @@ export function useOnboardingFlow() {
       setServerLicenseSource((prev) => prev ?? (isAdminUser ? 'config' : 'self-reported'));
       setServerLicenseIntent((prev) => (prev === 'pending' ? prev : 'pending'));
     }
-    maybeShowCookieBanner();
   }, [
     completeTour,
     isAdminUser,
-    maybeShowCookieBanner,
     serverLicenseIntent,
     serverLicenseSource,
     tourType,

frontend/src/core/components/shared/Footer.tsx

@@ -1,6 +1,6 @@
 import { Flex } from '@mantine/core';
 import { useTranslation } from 'react-i18next';
-import { useCookieConsentContext } from '@app/contexts/CookieConsentContext';
+import { useCookieConsent } from '@app/hooks/useCookieConsent';
 
 interface FooterProps {
   privacyPolicy?: string;
@@ -20,7 +20,7 @@ export default function Footer({
   analyticsEnabled = false
 }: FooterProps) {
   const { t } = useTranslation();
-  const { showCookiePreferences } = useCookieConsentContext();
+  const { showCookiePreferences } = useCookieConsent({ analyticsEnabled });
 
   // Helper to check if a value is valid (not null/undefined/empty string)
   const isValidLink = (link?: string) => link && link.trim().length > 0;