mirror of
https://github.com/arsvendg/Stirling-PDF.git
synced 2026-07-16 19:33:11 +02:00
Audit viewer making api call when shouldnt (#5069)
# Description of Changes <!-- Please provide a summary of the changes, including: - What was changed - Why the change was made - Any challenges encountered Closes #(issue_number) --> --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details.
This commit is contained in:
@@ -4,7 +4,7 @@ import auditService, { AuditFilters } from '@app/services/auditService';
|
|||||||
/**
|
/**
|
||||||
* Shared hook for managing audit filters across components
|
* Shared hook for managing audit filters across components
|
||||||
*/
|
*/
|
||||||
export function useAuditFilters(initialFilters: Partial<AuditFilters> = {}) {
|
export function useAuditFilters(initialFilters: Partial<AuditFilters> = {}, loginEnabled: boolean = true) {
|
||||||
const [eventTypes, setEventTypes] = useState<string[]>([]);
|
const [eventTypes, setEventTypes] = useState<string[]>([]);
|
||||||
const [users, setUsers] = useState<string[]>([]);
|
const [users, setUsers] = useState<string[]>([]);
|
||||||
const [filters, setFilters] = useState<AuditFilters>({
|
const [filters, setFilters] = useState<AuditFilters>({
|
||||||
@@ -30,8 +30,10 @@ export function useAuditFilters(initialFilters: Partial<AuditFilters> = {}) {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
if (loginEnabled) {
|
||||||
fetchMetadata();
|
fetchMetadata();
|
||||||
}, []);
|
}
|
||||||
|
}, [loginEnabled]);
|
||||||
|
|
||||||
const handleFilterChange = (key: keyof AuditFilters, value: any) => {
|
const handleFilterChange = (key: keyof AuditFilters, value: any) => {
|
||||||
setFilters((prev) => ({ ...prev, [key]: value }));
|
setFilters((prev) => ({ ...prev, [key]: value }));
|
||||||
|
|||||||
+1
-1
@@ -35,7 +35,7 @@ const AuditEventsTable: React.FC<AuditEventsTableProps> = ({ loginEnabled = true
|
|||||||
const { filters, eventTypes, users, handleFilterChange, handleClearFilters } = useAuditFilters({
|
const { filters, eventTypes, users, handleFilterChange, handleClearFilters } = useAuditFilters({
|
||||||
page: 0,
|
page: 0,
|
||||||
pageSize: 20,
|
pageSize: 20,
|
||||||
});
|
}, loginEnabled);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
const fetchEvents = async () => {
|
const fetchEvents = async () => {
|
||||||
|
|||||||
+1
-1
@@ -23,7 +23,7 @@ const AuditExportSection: React.FC<AuditExportSectionProps> = ({ loginEnabled =
|
|||||||
const [exporting, setExporting] = useState(false);
|
const [exporting, setExporting] = useState(false);
|
||||||
|
|
||||||
// Use shared filters hook
|
// Use shared filters hook
|
||||||
const { filters, eventTypes, users, handleFilterChange, handleClearFilters } = useAuditFilters();
|
const { filters, eventTypes, users, handleFilterChange, handleClearFilters } = useAuditFilters({}, loginEnabled);
|
||||||
|
|
||||||
const handleExport = async () => {
|
const handleExport = async () => {
|
||||||
if (!loginEnabled) return;
|
if (!loginEnabled) return;
|
||||||
|
|||||||
Reference in New Issue
Block a user